From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42220 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOtPV-000179-A4 for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOtPT-0007NI-Vp for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:16:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9547) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOtPT-0007N8-LN for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:16:07 -0400 Message-ID: <4C18DC86.3060601@redhat.com> Date: Wed, 16 Jun 2010 16:15:34 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1276695761-16588-1-git-send-email-nab@linux-iscsi.org> In-Reply-To: <1276695761-16588-1-git-send-email-nab@linux-iscsi.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] [scsi-bus]: Changes for PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs v2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: kvm-devel , Hannes Reinecke , qemu-devel , FUJITA Tomonori , Paul Brook , Christoph Hellwig , Gerd Hoffmann Am 16.06.2010 15:42, schrieb Nicholas A. Bellinger: > From: Nicholas Bellinger > > Greetings, > > Attached is v2 for a series containing a handful of changes required for scsi-bus in order > to get PERSISTENT_RESERVE_OUT and MAINTENANCE CDBs working as expected. Thanks to Kevin Wolf > for pointing out the unnecessary SCSIRequest->cmd.xfer reassignments in scsi_req_length() from > the original series. > > Tested with Linux KVM guests and Megasas 8708EM2 HBA emulation + scsi-generic and > TCM_Loop target ports. > > Signed-off-by: Nicholas A. Bellinger Thanks, applied to the block branch. One more thing: You usually put things like [scsi-bus] in brackets so that they are removed by git am. I think this is actually useful information to have in the commit log, so would you mind leaving the brackets out for your next submissions? Kevin