From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45973 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOtdU-0007fr-BY
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:30:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OOtdT-0001gn-35
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:30:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36894)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1OOtdS-0001gZ-SP
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:30:35 -0400
Message-ID: <4C18DFD7.1090102@redhat.com>
Date: Wed, 16 Jun 2010 16:29:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH V4 2/3] qemu: Generic task offloading
	framework: threadlets
References: <20100616115404.10988.62371.stgit@localhost.localdomain>
	<20100616115656.10988.96529.stgit@localhost.localdomain>
	<4C18C4C8.8090901@redhat.com>
	<20100616142236.GA20052@shareable.org>
In-Reply-To: <20100616142236.GA20052@shareable.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: Gautham R Shenoy <ego@in.ibm.com>, Qemu-development List <qemu-devel@nongnu.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, Corentin Chary <corentin.chary@gmail.com>, Avi Kivity <avi@redhat.com>

On 06/16/2010 04:22 PM, Jamie Lokier wrote:
> Paolo Bonzini wrote:
>> These should be (at least for now) block-obj-$(CONFIG_POSIX).
>>
>>> +        while (QTAILQ_EMPTY(&(queue->request_list))&&
>>> +               (ret != ETIMEDOUT)) {
>>> +            ret = qemu_cond_timedwait(&(queue->cond),
>>> +					&(queue->lock), 10*100000);
>>> +        }
>>
>> Using qemu_cond_timedwait is a hack for not properly broadcasting the
>> condvar in flush_threadlet_queue.
>
> Are you sure?  It looks like it also expires idle threads after a
> fixed amount of idle time.

Unnecessary idle threads are immediately expired as soon as the 
threadlet exits if ncecessary, since here

+        queue->idle_threads++;
+
+check_exit:
+        if (queue->exit || ((queue->idle_threads > 0) &&
+            (queue->cur_threads > queue->min_threads))) {
+            /* We exit the queue or we retain minimum number of threads */
+            break;
+        }

queue->idle_threads > 0 will always be true (so maybe that should be 
changed into an assertion: "this thread is idle, so there must be idle 
threads").

The min/max_threads parameters of the queue are currently immutable, so 
it can never happen that a thread has to be expired while it's waiting. 
  It may well become true in the future, in which case the condvar will 
have to be broadcast when min_threads changes.

I may well be wrong of course. :)

Paolo