From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49834 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOu3Z-0006ER-LM
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:57:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOu3Y-0007Sq-9E
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:57:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20383)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OOu3Y-0007Sa-2A
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 10:57:32 -0400
Message-ID: <4C18E64C.1050002@redhat.com>
Date: Wed, 16 Jun 2010 16:57:16 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] block: fix physical_block_size calculation
References: <20100615155252.GB2364@lst.de>
In-Reply-To: <20100615155252.GB2364@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 15.06.2010 17:52, schrieb Christoph Hellwig:
> Both SCSI and virtio expect the physical block size relative to the
> logical block size.  So get the factor first before calculating the
> log2.  
> 
> Reported-by: Mike Cao <bcao@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

This one looks better. Fixed whitespace errors and applied to the block
branch.

Kevin