From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34158 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOxcp-0004yX-QA
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:46:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOxcl-0007bX-I8
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:46:11 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:39805)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OOxcl-0007bI-FE
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:46:07 -0400
Received: by iwn10 with SMTP id 10so6783791iwn.4
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 11:46:06 -0700 (PDT)
Message-ID: <4C191BEB.4020207@codemonkey.ws>
Date: Wed, 16 Jun 2010 13:46:03 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20100614202803.5259.85808.stgit@localhost.localdomain>	<4C1697F3.3090107@codemonkey.ws>
	<m3zkyvx9mh.fsf@trasno.mitica>	<1276705730.12015.964.camel@x201>
	<m3iq5istqw.fsf@trasno.mitica>
In-Reply-To: <m3iq5istqw.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RESEND PATCH] acpi_piix4: save gpe and pci
	hotplug slot status
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: blauwirbel@gmail.com, Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 06/16/2010 01:43 PM, Juan Quintela wrote:
> Alex Williamson<alex.williamson@redhat.com>  wrote:
>    
>> On Wed, 2010-06-16 at 17:47 +0200, Juan Quintela wrote:
>>      
>>> Anthony Liguori<anthony@codemonkey.ws>  wrote:
>>>        
>>>> On 06/14/2010 03:28 PM, Alex Williamson wrote:
>>>>          
>>>>> PCI hotplug currently doesn't work after a migration because
>>>>> we don't migrate the enable bits of the GPE state.  Pull hotplug
>>>>> structs into vmstate.
>>>>>
>>>>> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>>>>>
>>>>>            
>>>> Applied.  Thanks.
>>>>
>>>> Regards,
>>>>
>>>> Anthony Liguori
>>>>          
>>> I think this is better implemented as a subsection.  We didin't need
>>> this until hotplug arrived, I think that checking if any up/down are
>>> != 0 and then send it as subsections is a best way to do it.
>>>
>>> This way it could also be backported to stable.
>>>        
>> The slots aren't really the issue, they were mostly for completeness.
>> The key is gpe.en, which is likely always going to be all 1s for an ACPI
>> aware OS.  So if we test != 0, we're going to need that subsection in
>> 99% of the cases.  Maybe we can assume gpe.en is all set on the target,
>> but I don't really look forward to finding out the ways that might
>> break.  Thanks,
>>      
> We have never sent it before.  That means that the default value (for
> whatever value is it) should be working quite well.
>
> But it is not my call.
>    

This sounds like a case where we're sending broken state so we need to 
bump the version number.  Subsections don't eliminate the need to bump 
version numbers when we fundamentally screw up.

Regards,

Anthony Liguori

> Later, Juan.
>