[Qemu-devel] Re: [CFR 2/10] qmp: memsave command

[Anthony Liguori <aliguori@linux.vnet.ibm.com>]

On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote:
> memsave
> -------
>
> Save to disk virtual memory dump starting at 'val' of size 'size'.
>
> Arguments:
>
> - "val": the starting address (json-int)
>    

s/val/address/

> - "size": the memory size, in bytes (json-int)
>    

The number of bytes to dump.

> - "filename": file path (json-string)
>    

We really ought to return this memory as a Base64 encoded blob.

> Example:
>
> ->  { "execute": "memsave",
>               "arguments": { "val": 10,
>                              "size": 100,
>                              "filename": "/tmp/virtual-mem-dump" } }
> <- { "return": {} }
>
> Note: Depends on the current CPU.
>    

Ought to take a cpu_id and avoid the silliness of current CPU.

What happens if the virtual address range is non-existent?  What if it's 
only partially mapped?

Regards,

Anthony Liguori