From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34744 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOxft-0007zU-T8
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:49:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OOxfs-00088R-P6
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:49:21 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:50550)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OOxfs-00088G-Lf
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:49:20 -0400
Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237])
	by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5GIabV8010401
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 14:36:37 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o5GInJes109268
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 14:49:19 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	o5GInJnD029327
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 15:49:19 -0300
Message-ID: <4C191CAE.5010002@linux.vnet.ibm.com>
Date: Wed, 16 Jun 2010 13:49:18 -0500
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1276703160-7894-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1276703160-7894-3-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1276703160-7894-3-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [CFR 2/10] qmp: memsave command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote:
> memsave
> -------
>
> Save to disk virtual memory dump starting at 'val' of size 'size'.
>
> Arguments:
>
> - "val": the starting address (json-int)
>    

s/val/address/

> - "size": the memory size, in bytes (json-int)
>    

The number of bytes to dump.

> - "filename": file path (json-string)
>    

We really ought to return this memory as a Base64 encoded blob.

> Example:
>
> ->  { "execute": "memsave",
>               "arguments": { "val": 10,
>                              "size": 100,
>                              "filename": "/tmp/virtual-mem-dump" } }
> <- { "return": {} }
>
> Note: Depends on the current CPU.
>    

Ought to take a cpu_id and avoid the silliness of current CPU.

What happens if the virtual address range is non-existent?  What if it's 
only partially mapped?

Regards,

Anthony Liguori