From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53552 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOxjp-00039Z-CY
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:53:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OOxjo-0000KJ-7l
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:53:25 -0400
Received: from e36.co.us.ibm.com ([32.97.110.154]:41936)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1OOxjo-0000K5-2O
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 14:53:24 -0400
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com
	[9.17.195.226])
	by e36.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o5GInxgS024867
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 12:49:59 -0600
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o5GIrCZE133864
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 12:53:14 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id o5GIrCCA022893
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 12:53:12 -0600
Message-ID: <4C191D96.8070401@linux.vnet.ibm.com>
Date: Wed, 16 Jun 2010 13:53:10 -0500
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1276703160-7894-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1276703160-7894-8-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1276703160-7894-8-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [CFR 7/10] qmp: netdev_add command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On 06/16/2010 10:45 AM, Stefan Hajnoczi wrote:
> netdev_add
> ----------
>
> Add host network device.
>
> Arguments:
>
> - "type": the device type, "tap", "user", ... (json-string)
> - "id": the device's ID, must be unique (json-string)
> - device options
>    

I'd like to see those options enumerated in the spec.

We need to enumerate all of the failure conditions too.

Regards,

Anthony Liguori

> Example:
>
> ->  { "execute": "netdev_add", "arguments": { "type": "user", "id": "netdev1" } }
> <- { "return": {} }
>
> Note: The supported device options are the same ones supported by the '-net'
>        command-line argument, which are listed in the '-help' output or QEMU's
>        manual
>
>