From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42374 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OP14J-0006y9-EB for qemu-devel@nongnu.org; Wed, 16 Jun 2010 18:26:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OP14I-0004qB-4a for qemu-devel@nongnu.org; Wed, 16 Jun 2010 18:26:47 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:37685) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OP14H-0004q1-Sz for qemu-devel@nongnu.org; Wed, 16 Jun 2010 18:26:46 -0400 Received: by vws17 with SMTP id 17so3363284vws.4 for ; Wed, 16 Jun 2010 15:26:45 -0700 (PDT) Message-ID: <4C194FA2.7050501@codemonkey.ws> Date: Wed, 16 Jun 2010 17:26:42 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [CFR 6/10] cont command References: <1276619430-15871-1-git-send-email-aliguori@us.ibm.com> <1276619430-15871-7-git-send-email-aliguori@us.ibm.com> <20100616162544.GS13996@redhat.com> <4C190760.9070605@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino On 06/16/2010 05:05 PM, Juan Quintela wrote: > Anthony Liguori wrote: > >> On 06/16/2010 11:25 AM, Daniel P. Berrange wrote: >> >>> >>>> This is related to the commands, not QMP per se: >>>> >>>> Once that we are talking about "cont" command. There are two cases that >>>> we need to think of: >>>> >>>> - incoming migration: >>>> >>>> If you start with -incoming foo, and then run "cont" on the monitor >>>> without having started the migration .... corruption is ensured. >>>> >>>> >>> This is why '-incoming' command line arg should die, and be replaced >>> with a 'incoming' monitor command that would simply not allow 'cont' >>> to be run until it completed. >>> >>> For that matter, even with '-incoming' arg on command line we could >>> refuse to honour 'cont' until the incoming migration had been done. >>> >>> >> If we had an incoming migration command, I think we'd have to think >> careful about it's semantics. Is it reasonable to allow a machine >> that's otherwise running to do an incoming command? >> > It is the same problem that loadvm. > > And no, loadvm several times don't work well either. > It's supposed to. If it doesn't, then there's a bug somewhere. Regards, Anthony Liguori > Later, Juan. > >