From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47577 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPJhb-0001Jm-S3 for qemu-devel@nongnu.org; Thu, 17 Jun 2010 14:20:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPJha-0003g2-RS for qemu-devel@nongnu.org; Thu, 17 Jun 2010 14:20:35 -0400 Received: from mail-yw0-f180.google.com ([209.85.211.180]:48453) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPJha-0003fv-Of for qemu-devel@nongnu.org; Thu, 17 Jun 2010 14:20:34 -0400 Received: by ywh10 with SMTP id 10so186867ywh.18 for ; Thu, 17 Jun 2010 11:20:34 -0700 (PDT) Message-ID: <4C1A676E.5030002@codemonkey.ws> Date: Thu, 17 Jun 2010 13:20:30 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command References: <4C0F450B.5000802@redhat.com> <4C0FA4B9.7090906@redhat.com> <4C16600A.4030208@codemonkey.ws> <20100617151543.562ba3e1@redhat.com> In-Reply-To: <20100617151543.562ba3e1@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Marcos Oviedo , Markus Armbruster , Gerd Hoffmann On 06/17/2010 01:15 PM, Luiz Capitulino wrote: > This is a general question for all commands that can take way too long > or never return. > > For QMP the question is whether we should handle this in QEMU or in the > client. Ie, if the guest doesn't respond the client could detect that > and cancel the async command. > Exactly. It's no different than a migration that takes too long. > For HMP we could just live with that or suspend the shell and allow the > user to cancel the operation (eg. ctrl+c) and the obvious alternative is to > have timeouts, allowing the user to set them. > Yeah, ctrl+c to cancel would be a very nice feature. Regards, Anthony Liguori