qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org,
	armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev
Date: Fri, 18 Jun 2010 15:28:42 -0500	[thread overview]
Message-ID: <4C1BD6FA.7020502@codemonkey.ws> (raw)
In-Reply-To: <1276878387-9489-1-git-send-email-miguel.filho@gmail.com>

On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
> These commands show the information about active backend network devices.
>
> Signed-off-by: Miguel Di Ciurcio Filho<miguel.filho@gmail.com>
> ---
>   qemu-monitor.hx |  105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 105 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
> index 9f62b94..8fc5ed6 100644
> --- a/qemu-monitor.hx
> +++ b/qemu-monitor.hx
> @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices
>   ETEXI
>
>   STEXI
> +@item info netdev
> +show information about the current backend network devices
> +ETEXI
> +SQMP
> +query-netdev
> +------------
> +
> +Each device is represented by a json-object. The returned value is a json-array
> +of all devices.
> +
> +Each json-object contains the following:
> +
> +- "id": the device's ID, must be unique (json-string)
> +- "type": device type (json-string)
> +    - Possible values: "tap", "user", "vde", "socket"
> +- "vlan": QEMU's internal vlan identification. Only present if the device is
> +  attached to a VLAN (json-int, optional)
> +- "peer": ID of the frontend device when on a 1:1 relationship (json-string,
> +  optional)
>    

I think we should only return items with a valid peer property and drop 
anything attached to vlans.  The current info network already provides 
vlan information.

Regards,

Anthony Liguori

  reply	other threads:[~2010-06-18 20:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 16:26 [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev Miguel Di Ciurcio Filho
2010-06-18 20:28 ` Anthony Liguori [this message]
2010-06-18 20:40   ` Luiz Capitulino
2010-06-21  8:27     ` Markus Armbruster
2010-06-21 14:34       ` Luiz Capitulino
2010-06-18 21:15   ` Miguel Di Ciurcio Filho
2010-06-18 21:20     ` Anthony Liguori
2010-06-21  8:23   ` Markus Armbruster
2010-06-21 14:42 ` [Qemu-devel] " Luiz Capitulino
2010-06-21 14:47   ` Jan Kiszka
2010-06-21 16:44     ` Markus Armbruster
2010-06-22  8:50       ` Jan Kiszka
2010-06-22 11:53         ` Markus Armbruster
2010-06-21 17:58   ` Miguel Di Ciurcio Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1BD6FA.7020502@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).