From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43135 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OPiO9-0004kJ-3u
	for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:42:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OPiBF-0005WF-1f
	for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:28:49 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:37992)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OPiBE-0005W1-P4
	for qemu-devel@nongnu.org; Fri, 18 Jun 2010 16:28:48 -0400
Received: by gyd5 with SMTP id 5so1209749gyd.4
	for <qemu-devel@nongnu.org>; Fri, 18 Jun 2010 13:28:47 -0700 (PDT)
Message-ID: <4C1BD6FA.7020502@codemonkey.ws>
Date: Fri, 18 Jun 2010 15:28:42 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for
	query-netdev and info netdev
References: <1276878387-9489-1-git-send-email-miguel.filho@gmail.com>
In-Reply-To: <1276878387-9489-1-git-send-email-miguel.filho@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: avi@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote:
> These commands show the information about active backend network devices.
>
> Signed-off-by: Miguel Di Ciurcio Filho<miguel.filho@gmail.com>
> ---
>   qemu-monitor.hx |  105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 105 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
> index 9f62b94..8fc5ed6 100644
> --- a/qemu-monitor.hx
> +++ b/qemu-monitor.hx
> @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices
>   ETEXI
>
>   STEXI
> +@item info netdev
> +show information about the current backend network devices
> +ETEXI
> +SQMP
> +query-netdev
> +------------
> +
> +Each device is represented by a json-object. The returned value is a json-array
> +of all devices.
> +
> +Each json-object contains the following:
> +
> +- "id": the device's ID, must be unique (json-string)
> +- "type": device type (json-string)
> +    - Possible values: "tap", "user", "vde", "socket"
> +- "vlan": QEMU's internal vlan identification. Only present if the device is
> +  attached to a VLAN (json-int, optional)
> +- "peer": ID of the frontend device when on a 1:1 relationship (json-string,
> +  optional)
>    

I think we should only return items with a valid peer property and drop 
anything attached to vlans.  The current info network already provides 
vlan information.

Regards,

Anthony Liguori