From: Jan Kiszka <jan.kiszka@siemens.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "avi@redhat.com" <avi@redhat.com>,
Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev
Date: Tue, 22 Jun 2010 10:50:42 +0200 [thread overview]
Message-ID: <4C207962.2040000@siemens.com> (raw)
In-Reply-To: <m3bpb4z67j.fsf@blackfin.pond.sub.org>
Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@siemens.com> writes:
>
>> Luiz Capitulino wrote:
>>> On Fri, 18 Jun 2010 13:26:27 -0300
>>> Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:
>>>
>>>> These commands show the information about active backend network devices.
>>>>
>>>> Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
>>>> ---
>>>> qemu-monitor.hx | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>> 1 files changed, 105 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>>>> index 9f62b94..8fc5ed6 100644
>>>> --- a/qemu-monitor.hx
>>>> +++ b/qemu-monitor.hx
>>>> @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices
>>>> ETEXI
>>>>
>>>> STEXI
>>>> +@item info netdev
>>>> +show information about the current backend network devices
>>>> +ETEXI
>>>> +SQMP
>>>> +query-netdev
>>>> +------------
>>>> +
>>>> +Each device is represented by a json-object. The returned value is a json-array
>>>> +of all devices.
>>>> +
>>>> +Each json-object contains the following:
>>>> +
>>>> +- "id": the device's ID, must be unique (json-string)
>>> There were some talking about changing this to 'device. Jan, Markus?
>> Only for qdev. Should be a different namespace here.
>
> Huh?
>
> We need to point to the NIC here, i.e. we need a unambigous name.
> Device ID is fine, but it's optional. Canonical qdev path?
Unless I'm still on the wrong track: 'peer' should point to the
front-end, this ID describes the back-end, and that's not a qdev thing.
Still, dumping the peer's qdev path along its (optional) ID might be
worth a thought.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2010-06-22 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 16:26 [Qemu-devel] [PATCH v2] QMP: Introduce the documentation for query-netdev and info netdev Miguel Di Ciurcio Filho
2010-06-18 20:28 ` Anthony Liguori
2010-06-18 20:40 ` Luiz Capitulino
2010-06-21 8:27 ` Markus Armbruster
2010-06-21 14:34 ` Luiz Capitulino
2010-06-18 21:15 ` Miguel Di Ciurcio Filho
2010-06-18 21:20 ` Anthony Liguori
2010-06-21 8:23 ` Markus Armbruster
2010-06-21 14:42 ` [Qemu-devel] " Luiz Capitulino
2010-06-21 14:47 ` Jan Kiszka
2010-06-21 16:44 ` Markus Armbruster
2010-06-22 8:50 ` Jan Kiszka [this message]
2010-06-22 11:53 ` Markus Armbruster
2010-06-21 17:58 ` Miguel Di Ciurcio Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C207962.2040000@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).