Re: [Qemu-devel] [PATCH v4 03/23] qdev: Drop ID matching from qtree paths

[Jan Kiszka <jan.kiszka@siemens.com>]

Markus Armbruster wrote:
> [cc: kraxel]
> 
> Jan Kiszka <jan.kiszka@web.de> writes:
> 
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Device IDs may conflict with device names or aliases. From now on we
>> only accept them outside qtree paths. This also makes dumping IDs in
>> qbus_list_dev/bus obsolete.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> I don't like this at all.
> 
> 1. Specific problem:
> 
>    With the current code, multiple devices with the same driver work
>    only if I take care: addressing by driver name gets me only the
>    first, so I better set suitable IDs.
> 
>    With your patch, multiple devices with the same driver don't work, no
>    matter what I do.

[ you already found how this is resolved ]

> 
> 2. General principle:
> 
>    When I set an ID, I want the system to accept that ID in all contexts
>    where it makes sense.  Ambiguity created by badly chosen IDs is *my*
>    problem.

I disagree. IMO, QEMU should support the user to avoid such subtle
shadowing.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux