From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48698 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ORR3A-00052f-Mc
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:35:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ORR37-0000iR-2y
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:35:36 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:64760)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ORR36-0000i6-VI
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:35:33 -0400
Received: by wyb42 with SMTP id 42so1516039wyb.4
	for <qemu-devel@nongnu.org>; Wed, 23 Jun 2010 07:35:31 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C221BAE.3010701@redhat.com>
Date: Wed, 23 Jun 2010 16:35:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <34d91ff747d586261f56ba024d2fe9f8734180f6.1277303360.git.amit.shah@redhat.com>
In-Reply-To: <34d91ff747d586261f56ba024d2fe9f8734180f6.1277303360.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] rtc: Parse the 'driftfix' option only
	for TARGET_I386
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu list <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, Juan Quintela <quintela@redhat.com>

On 06/23/2010 04:29 PM, Amit Shah wrote:
> The driftfix option is only useful for Windows guests, and for the x86
> architecture, so limit the option parsing to TARGET_I386. This ifdef
> conditional is moved from qemu-config.c to vl.c. The next patch will fix
> a bug where the driftfix option wasn't exposed at all even to the x86
> architecture.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
> ---
>   vl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 920717a..f9c8086 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -418,6 +418,7 @@ static void configure_rtc(QemuOpts *opts)
>               exit(1);
>           }
>       }
> +#ifdef TARGET_I386
>       value = qemu_opt_get(opts, "driftfix");
>       if (value) {
>           if (!strcmp(value, "slew")) {
> @@ -429,6 +430,7 @@ static void configure_rtc(QemuOpts *opts)
>               exit(1);
>           }
>       }
> +#endif
>   }
>
>   /***********************************************************/

This file is compiled only once for upstream qemu, so it will never see 
TARGET_I386.  Any reason to have the #ifdef at all?

Paolo