From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38000 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ORRHy-0003a7-8A
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:50:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1ORRHx-00035l-0U
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:50:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19572)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1ORRHw-00035U-Ph
	for qemu-devel@nongnu.org; Wed, 23 Jun 2010 10:50:52 -0400
Message-ID: <4C221F48.7010403@redhat.com>
Date: Wed, 23 Jun 2010 16:50:48 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
In-Reply-To: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] rtc: Remove TARGET_I386 from
 qemu-config.c, enables driftfix
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu list <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, Juan Quintela <quintela@redhat.com>

On 06/23/2010 04:44 PM, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
> ---
>   qemu-config.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-config.c b/qemu-config.c
> index 95abe61..730ffd9 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
>           },{
>               .name = "clock",
>               .type = QEMU_OPT_STRING,
> -#ifdef TARGET_I386
>           },{
>               .name = "driftfix",
>               .type = QEMU_OPT_STRING,
> -#endif
>           },
>           { /* end if list */ }
>       },

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo