From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORjGc-0000df-8r for qemu-devel@nongnu.org; Thu, 24 Jun 2010 06:02:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORjGa-0001An-G9 for qemu-devel@nongnu.org; Thu, 24 Jun 2010 06:02:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11162) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORjGa-0001AZ-9Z for qemu-devel@nongnu.org; Thu, 24 Jun 2010 06:02:40 -0400 Message-ID: <4C232D3B.8050307@redhat.com> Date: Thu, 24 Jun 2010 12:02:35 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , Jan Kiszka , qemu list , Gleb Natapov , Juan Quintela On 06/23/10 16:44, Amit Shah wrote: > qemu-config.c doesn't contain any target-specific code, and the > TARGET_I386 conditional code didn't get compiled as a result. Removing > this enables the driftfix parameter for rtc. > > Signed-off-by: Amit Shah > --- > qemu-config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) I really don't like exposing all these options in targets where they are not functional. It would be really nice if we could come up with a better way to handle this without just exposing them globally. Cheers, Jes