From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] Re: [PATCH 2/2] tcg-s390: New TCG Target.
Date: Fri, 25 Jun 2010 09:45:01 -0700 [thread overview]
Message-ID: <4C24DD0D.8000404@twiddle.net> (raw)
In-Reply-To: <20100617194019.GA3085@hall.aurel32.net>
On 06/17/2010 12:40 PM, Aurelien Jarno wrote:
>> + /* Handle the modifiers. */
>> + if (ct & TCG_CT_CONST_NEG) {
>> + val = -val;
>> + }
>
> This "modifier" is only used by subi. Wouldn't it be better to use a
> TCG_CT_CONST_SUBI instead?
Not really. This negation needs to happen *before* the sign-extension
of TCG_CT_CONST_32 in order to get correct results.
While I could do a CONST_SUBI, I would have to handle CONST_32 again
within the CONST_SUBI clause and I would not consider that better.
r~
prev parent reply other threads:[~2010-06-25 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 0:35 [Qemu-devel] [PATCH 0/2] S390 TCG Port, version 4 Richard Henderson
2010-06-15 0:35 ` [Qemu-devel] [PATCH 1/2] tcg: Optionally sign-extend 32-bit arguments for 64-bit hosts Richard Henderson
2010-06-16 9:26 ` [Qemu-devel] " Aurelien Jarno
2010-06-15 0:35 ` [Qemu-devel] [PATCH 2/2] tcg-s390: New TCG Target Richard Henderson
2010-06-17 19:40 ` [Qemu-devel] " Aurelien Jarno
2010-06-25 16:45 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C24DD0D.8000404@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).