From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44113 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OSCvQ-00026K-Tz
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:42:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OSCID-00042L-CS
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:02:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40759)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OSCID-00042D-4r
	for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:02:17 -0400
Message-ID: <4C24E111.7080606@redhat.com>
Date: Fri, 25 Jun 2010 19:02:09 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific
	files
References: <1276162951-842-1-git-send-email-Jes.Sorensen@redhat.com>	
	<1276162951-842-15-git-send-email-Jes.Sorensen@redhat.com>
	<1277484082.24464.24.camel@mendozza.osrc.amd.com>
In-Reply-To: <1277484082.24464.24.camel@mendozza.osrc.amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frank Arnold <frank.arnold@amd.com>
Cc: Andre Przywara <andre.przywara@amd.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 06/25/10 18:41, Frank Arnold wrote:
> On Thu, 2010-06-10 at 05:42 -0400, Jes.Sorensen@redhat.com wrote:
>> diff --git a/os-posix.c b/os-posix.c
>> index 6417d16..1672e06 100644
>> --- a/os-posix.c
>> +++ b/os-posix.c
>> @@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optarg)
>>      case QEMU_OPTION_chroot:
>>          chroot_dir = optarg;
>>          break;
>> +    case QEMU_OPTION_daemonize:
>> +        daemonize = 1;
>> +        break;
>>      }
>>      return;
>>  }
> 
> This move broke the -daemonize option for us. We are using the qemu-kvm
> tree.
> 
> The issue is that the QEMU_OPTION_* enumeration between vl.c and
> os-posix.c is out of sync. In our case MAP_POPULATE is defined in vl.c
> but is not in os-posix.c. This excludes the option -mem-prealloc in
> os-posix.c, see qemu-options.def for the ifdef statement. All subsequent
> options are off by one in comparison to vl.c.
> 
> Just including sys/mman.h in os-posix.c fixes the issue for me. But I'm
> not sure if there is a more generic fix to that problem.

Thanks for the update. What do you mean that it changes the numbering,
do you get a compile time error or are you saying that it is the order
of parsing the options that change?

Are you building on Linux or another OS?

Cheers,
Jes