From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39726 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OSrI0-0000vy-FI
	for qemu-devel@nongnu.org; Sun, 27 Jun 2010 08:48:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OSrHz-0000wz-A3
	for qemu-devel@nongnu.org; Sun, 27 Jun 2010 08:48:48 -0400
Received: from fg-out-1718.google.com ([72.14.220.153]:32835)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OSrHz-0000wr-5O
	for qemu-devel@nongnu.org; Sun, 27 Jun 2010 08:48:47 -0400
Received: by fg-out-1718.google.com with SMTP id l26so24241fgb.8
	for <qemu-devel@nongnu.org>; Sun, 27 Jun 2010 05:48:46 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C2748AA.8040806@redhat.com>
Date: Sun, 27 Jun 2010 14:48:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1277470342-5861-1-git-send-email-pbonzini@redhat.com>	<1277470342-5861-6-git-send-email-pbonzini@redhat.com>
	<m3r5juutgx.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3r5juutgx.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/7] add qdev property type "cpu"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org

> Hmm.  Parse method doesn't accept output of the print method.  Not so
> nice.  Is the "CPU #" decoration essential?

I noticed the same in parse/print string:

static int parse_string(DeviceState *dev, Property *prop, const char *str)
{
     char **ptr = qdev_get_prop_ptr(dev, prop);

     if (*ptr)
         qemu_free(*ptr);
     *ptr = qemu_strdup(str);
     return 0;
}

static int print_string(DeviceState *dev, Property *prop, char *dest, 
size_t len)
{
     char **ptr = qdev_get_prop_ptr(dev, prop);
     if (!*ptr)
         return snprintf(dest, len, "<null>");
     return snprintf(dest, len, "\"%s\"", *ptr);
}

It looks like printing representation is chosen "for the user", not for 
parsing.

Paolo