From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36723 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OTGnr-00018G-Qb
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:03:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OTGno-0007if-KJ
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:03:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39959)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1OTGno-0007iI-Dc
	for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:03:20 -0400
Message-ID: <4C28C7C1.4030409@redhat.com>
Date: Mon, 28 Jun 2010 18:03:13 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific
	files
References: <1276162951-842-1-git-send-email-Jes.Sorensen@redhat.com>
	<1276162951-842-15-git-send-email-Jes.Sorensen@redhat.com>
	<1277484082.24464.24.camel@mendozza.osrc.amd.com>
	<4C24E111.7080606@redhat.com>
	<1277487263.24464.37.camel@mendozza.osrc.amd.com>
	<4C28B6C2.4030807@redhat.com>
	<AANLkTikjK2ygkTBPDijNoQCIzSKvJvXrwtrSbr4JbeSf@mail.gmail.com>
In-Reply-To: <AANLkTikjK2ygkTBPDijNoQCIzSKvJvXrwtrSbr4JbeSf@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Frank Arnold <frank.arnold@amd.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Przywara,
	Andre" <Andre.Przywara@amd.com>

On 06/28/10 17:42, Blue Swirl wrote:
> On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
>> I figured out what was causing it. qemu-options.def has an
>> #ifdef MAP_POPULATE in it, which isn't being set without sys/mmap.h
>> being included. Pretty much every other #ifdef in qemu-options.def are
>> based on CONFIG_foo settings or things like _WIN32 which do not change
>> depending on header file inclusion.
>>
>> I think the easiest fix is to just add sys/mmap.h to the include list in
>> os-posix.c, so I just posted a patch for that. Though, in principle we
>> really shouldn't base qemu-options.def settings on defines pulled in
>> from system header files.
> 
> I think more flags should be added to arch_mask field, like
> QEMU_ARCH_LINUX, QEMU_ARCH_POSIX and QEMU_ARCH_WIN32. Then the #ifdefs
> should be removed. Prealloc command line flag stuff should be
> conditional to CONFIG_LINUX only, there should be another check for
> MAP_POPULATE where mem_preallocate is set.
> 
> Alternatively, we could have more arch_mask flags like QEMU_MAP_POPULATE.

Yeah, the problem with tying it to CONFIG_LINUX is that older version of
Linux may not support it. Looking through the list, MAP_POPULATE is
really an oddball in there though, so maybe it would be cleaner to catch
it via configure and then use CONFIG_MAP_POPULATE or something like that?

Cheers,
Jes