From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Frank Arnold <frank.arnold@amd.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Przywara, Andre" <Andre.Przywara@amd.com>
Subject: Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files
Date: Mon, 28 Jun 2010 18:30:57 +0200 [thread overview]
Message-ID: <4C28CE41.3090000@redhat.com> (raw)
In-Reply-To: <AANLkTin2tsokRf-PwydDv34rRKWAAx2Hddcf2yFmyAwa@mail.gmail.com>
On 06/28/10 18:20, Blue Swirl wrote:
> On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
>> Yeah, the problem with tying it to CONFIG_LINUX is that older version of
>> Linux may not support it. Looking through the list, MAP_POPULATE is
>> really an oddball in there though, so maybe it would be cleaner to catch
>> it via configure and then use CONFIG_MAP_POPULATE or something like that?
>
> There'd be 1:1 relation between MAP_POPULATE and CONFIG_MAP_POPULATE,
> so maybe not.
That is correct, but CONFIG_MAP_POPULATE would be in config.h so it
would not get missed out in cases where someone includes qemu-options.h
without including sys/mmap.h first. But it is a corner case, so my patch
should be fine.
Cheers,
Jes
next prev parent reply other threads:[~2010-06-28 16:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 9:42 [Qemu-devel] [PATCH v4 00/17] clean up vl.c code Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 02/17] Create qemu-os-win32.h and move WIN32 specific declarations there Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 03/17] Introduce os-win32.c and move polling functions from vl.c Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 04/17] vl.c: Move host_main_loop_wait() to OS specific files Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 05/17] Introduce os-posix.c and create os_setup_signal_handling() Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 06/17] Move win32 early signal handling setup to os_setup_signal_handling() Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 07/17] Rename os_setup_signal_handling() to os_setup_early_signal_handling() Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 08/17] Move main signal handler setup to os specificfiles Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 09/17] Move find_datadir to OS specific files Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 10/17] Rename qemu-options.h to qemu-options.def Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 12/17] Move runas handling from vl.c to OS specific files Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 13/17] Move chroot handling " Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 14/17] Move daemonize " Jes.Sorensen
2010-06-25 16:41 ` Frank Arnold
2010-06-25 17:02 ` Jes Sorensen
2010-06-25 17:34 ` Frank Arnold
2010-06-25 17:45 ` Frank Arnold
2010-06-28 9:30 ` Jes Sorensen
2010-06-28 14:50 ` Jes Sorensen
2010-06-28 15:42 ` Blue Swirl
2010-06-28 16:03 ` Jes Sorensen
2010-06-28 16:20 ` Blue Swirl
2010-06-28 16:30 ` Jes Sorensen [this message]
2010-06-28 16:46 ` [Qemu-devel] " Paolo Bonzini
2010-06-10 9:42 ` [Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files Jes.Sorensen
2010-06-10 9:42 ` [Qemu-devel] [PATCH 17/17] Move set_proc_name() " Jes.Sorensen
2010-06-12 6:33 ` [Qemu-devel] [PATCH v4 00/17] clean up vl.c code Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2010-06-04 16:08 [Qemu-devel] [PATCH v3 " Jes.Sorensen
2010-06-04 16:09 ` [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files Jes.Sorensen
2010-06-04 13:24 [Qemu-devel] [PATCH v2 00/17] clean up vl.c code Jes.Sorensen
2010-06-04 13:24 ` [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C28CE41.3090000@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Andre.Przywara@amd.com \
--cc=blauwirbel@gmail.com \
--cc=frank.arnold@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).