From: Kevin Wolf <kwolf@redhat.com>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Don't reset bs->is_temporary in bdrv_open_common
Date: Tue, 29 Jun 2010 09:32:13 +0200 [thread overview]
Message-ID: <4C29A17D.6090701@redhat.com> (raw)
In-Reply-To: <20100628143833.GB1647@us.ibm.com>
Am 28.06.2010 16:38, schrieb Ryan Harper:
> To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to
> call unlink() on temporary snapshots due to bs->is_temporary getting clobbered
> in bdrv_open_common() after being set in bdrv_open() which calls the former.
>
> We don't need to initialize bs->is_temporary in bdrv_open_common().
>
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2010-06-29 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:38 [Qemu-devel] [PATCH] Don't reset bs->is_temporary in bdrv_open_common Ryan Harper
2010-06-29 7:32 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C29A17D.6090701@redhat.com \
--to=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).