From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32887 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OTVJG-0007AE-57
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:32:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OTVJ6-0000lW-Dk
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:32:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44833)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OTVJ6-0000l7-5e
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:32:36 -0400
Message-ID: <4C29A17D.6090701@redhat.com>
Date: Tue, 29 Jun 2010 09:32:13 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20100628143833.GB1647@us.ibm.com>
In-Reply-To: <20100628143833.GB1647@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Don't reset bs->is_temporary in
	bdrv_open_common
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 28.06.2010 16:38, schrieb Ryan Harper:
> To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to
> call unlink() on temporary snapshots due to bs->is_temporary getting clobbered
> in bdrv_open_common() after being set in bdrv_open() which calls the former.
> 
> We don't need to initialize bs->is_temporary in bdrv_open_common().
> 
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

Thanks, applied to the block branch.

Kevin