From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56644 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OTVYe-0003j9-Ig
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:48:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OTVYd-0003Tt-GP
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:48:40 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:48432)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OTVYd-0003To-Db
	for qemu-devel@nongnu.org; Tue, 29 Jun 2010 03:48:39 -0400
Received: by vws14 with SMTP id 14so1848980vws.4
	for <qemu-devel@nongnu.org>; Tue, 29 Jun 2010 00:48:38 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C29A552.6060004@redhat.com>
Date: Tue, 29 Jun 2010 09:48:34 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1277745445-30560-1-git-send-email-pbonzini@redhat.com>
	<1277745445-30560-2-git-send-email-pbonzini@redhat.com>
	<AANLkTinzH2AQ-ZXO764y71TYl8ZxeNeIPxnHffZyXDHT@mail.gmail.com>
In-Reply-To: <AANLkTinzH2AQ-ZXO764y71TYl8ZxeNeIPxnHffZyXDHT@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/4] remove unused stuff from */exec.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 06/28/2010 07:43 PM, Blue Swirl wrote:
> IIRC these #undefs were added because some system includes on some
> hosts also defined them. I think they should be replaced by open coded
> versions (rather than using the QEMU_ prefix). Or just leave the
> #undefs in place.

Right, I confused them with reg_EAX/reg_EBX/etc.  They were introduced in:

commit aba1d00a41d5aff5fc78bf924627b89a298a5a5a
Author: Blue Swirl <blauwirbel@gmail.com>
Date:   Sat Sep 12 12:36:11 2009 +0000

     Work around OpenSolaris sys/regset.h namespace pollution

     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Paolo