From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41510 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTbEC-0003le-Ek for qemu-devel@nongnu.org; Tue, 29 Jun 2010 09:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTbEB-0000FF-CE for qemu-devel@nongnu.org; Tue, 29 Jun 2010 09:51:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51514) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTbEB-0000Ey-4D for qemu-devel@nongnu.org; Tue, 29 Jun 2010 09:51:55 -0400 Message-ID: <4C29FA67.3070605@redhat.com> Date: Tue, 29 Jun 2010 15:51:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable References: <1277745445-30560-1-git-send-email-pbonzini@redhat.com> <201006282129.34080.paul@codesourcery.com> <4C29A478.1080805@redhat.com> <201006291230.18759.paul@codesourcery.com> In-Reply-To: <201006291230.18759.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org On 06/29/2010 01:30 PM, Paul Brook wrote: > I don't understand what this is supposed to achieve. > The inclusion of exec.h is what defines whether this global variable is > available. Just as importantly, it also prevents code clobbering this value. > Having one without the other makes no sense. > > Making "env" available without including exec.h would be a different problem, > but we never do that and would probably indicate we're doing something else > wrong. Paul, I agree but I was told to do something different. Paolo