From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52914 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUEDN-0001Rl-SB for qemu-devel@nongnu.org; Thu, 01 Jul 2010 03:29:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUEDJ-0006Ue-C7 for qemu-devel@nongnu.org; Thu, 01 Jul 2010 03:29:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1027) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUEDJ-0006UI-4J for qemu-devel@nongnu.org; Thu, 01 Jul 2010 03:29:37 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o617TZS9005452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Jul 2010 03:29:35 -0400 Message-ID: <4C2C43D8.20308@redhat.com> Date: Thu, 01 Jul 2010 09:29:28 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] blkdebug: Free QemuOpts after having read the config References: <1277912914-21771-1-git-send-email-kwolf@redhat.com> <1277912914-21771-3-git-send-email-kwolf@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Am 01.07.2010 08:47, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Forgetting to free them means that the next instance inherits all rules and >> gets its own rules only additionally. > > I also found a use for freeing a complete QemuOptsList, here's my > solution. The code that needs it isn't ready, yet. If you'd like to > use it, I can push it to my repo. If you have a use for it, it's the better solution. I'll rebase on top of this as soon as you have sent it as a proper patch. Kevin