From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36940 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUII6-0008Dr-Rk for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUII5-0004vv-RO for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:50:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65047) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUII5-0004v1-Ki for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:50:49 -0400 Message-ID: <4C2C8110.2090200@redhat.com> Date: Thu, 01 Jul 2010 13:50:40 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] win32: Add missing function setenv References: <1277981269-751-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1277981269-751-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers On 07/01/10 12:47, Stefan Weil wrote: > Mingw32 does not provide a declaration and implementation of function > setenv (which is used in sdl.c), so this patch adds both. > > Signed-off-by: Stefan Weil [snip] > diff --git a/osdep.h b/osdep.h > index 75b5816..1cdc7e2 100644 > --- a/osdep.h > +++ b/osdep.h > @@ -95,6 +95,8 @@ int qemu_create_pidfile(const char *filename); > #ifdef _WIN32 > int ffs(int i); > > +int setenv(const char *name, const char *value, int overwrite); > + > typedef struct { > long tv_sec; > long tv_usec; Please move this to qemu-os-win32.h instead, otherwise the build will fail on POSIX systems due to setenv being redefined. Thanks, Jes