From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59679 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUJkb-0005bS-0i for qemu-devel@nongnu.org; Thu, 01 Jul 2010 09:24:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUJka-0006P1-3f for qemu-devel@nongnu.org; Thu, 01 Jul 2010 09:24:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62670) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUJkZ-0006Ox-Qh for qemu-devel@nongnu.org; Thu, 01 Jul 2010 09:24:20 -0400 Message-ID: <4C2C96FF.8050000@redhat.com> Date: Thu, 01 Jul 2010 15:24:15 +0200 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] win32: Add missing function setenv References: <1277981269-751-1-git-send-email-weil@mail.berlios.de> <4C2C8110.2090200@redhat.com> <4C2C968B.40007@mail.berlios.de> In-Reply-To: <4C2C968B.40007@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers On 07/01/10 15:22, Stefan Weil wrote: > It won't fail for two reasons: > > * It is not redefined (at least for linux systems) because I used the > POSIX declaration. This still fails with strict compiler flags. > * It is compiled only for _WIN32 (see line 95). True, but we need to move stuff out of osdep.h and into the other files as much as possible, so it is still preferred that you move it. Cheers, Jes