From: Stefan Weil <weil@mail.berlios.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] win32: Add missing function setenv
Date: Thu, 01 Jul 2010 17:51:28 +0200 [thread overview]
Message-ID: <4C2CB980.9000909@mail.berlios.de> (raw)
In-Reply-To: <4C2C96FF.8050000@redhat.com>
Am 01.07.2010 15:24, schrieb Jes Sorensen:
> On 07/01/10 15:22, Stefan Weil wrote:
>> It won't fail for two reasons:
>>
>> * It is not redefined (at least for linux systems) because I used the
>> POSIX declaration.
>
> This still fails with strict compiler flags.
>
>> * It is compiled only for _WIN32 (see line 95).
>
> True, but we need to move stuff out of osdep.h and into the other files
> as much as possible, so it is still preferred that you move it.
That's a valid argument. As there is more stuff to move out of osdep.h,
I suggest doing that in a second step. Now, it is most important to get
Windows builds working again (they fail currently with a linker error).
>
> Cheers,
> Jes
>
Cheers,
Stefan
next prev parent reply other threads:[~2010-07-01 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 10:47 [Qemu-devel] [PATCH] win32: Add missing function setenv Stefan Weil
2010-07-01 11:50 ` Jes Sorensen
2010-07-01 13:22 ` Stefan Weil
2010-07-01 13:24 ` Jes Sorensen
2010-07-01 15:51 ` Stefan Weil [this message]
2010-07-01 15:53 ` Jes Sorensen
2010-07-01 17:53 ` Stefan Weil
2010-07-02 8:40 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2CB980.9000909@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).