From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52164 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUM33-0008Rm-TL for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUM32-0004AF-EZ for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:51:33 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:58707) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUM32-00049z-2z for qemu-devel@nongnu.org; Thu, 01 Jul 2010 11:51:32 -0400 Message-ID: <4C2CB980.9000909@mail.berlios.de> Date: Thu, 01 Jul 2010 17:51:28 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] win32: Add missing function setenv References: <1277981269-751-1-git-send-email-weil@mail.berlios.de> <4C2C8110.2090200@redhat.com> <4C2C968B.40007@mail.berlios.de> <4C2C96FF.8050000@redhat.com> In-Reply-To: <4C2C96FF.8050000@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: QEMU Developers Am 01.07.2010 15:24, schrieb Jes Sorensen: > On 07/01/10 15:22, Stefan Weil wrote: >> It won't fail for two reasons: >> >> * It is not redefined (at least for linux systems) because I used the >> POSIX declaration. > > This still fails with strict compiler flags. > >> * It is compiled only for _WIN32 (see line 95). > > True, but we need to move stuff out of osdep.h and into the other files > as much as possible, so it is still preferred that you move it. That's a valid argument. As there is more stuff to move out of osdep.h, I suggest doing that in a second step. Now, it is most important to get Windows builds working again (they fail currently with a linker error). > > Cheers, > Jes > Cheers, Stefan