Re: [Qemu-devel] [PATCH] win32: Add missing function setenv

[Stefan Weil <weil@mail.berlios.de>]

Am 01.07.2010 17:53, schrieb Jes Sorensen:
> On 07/01/10 17:51, Stefan Weil wrote:
>    
>> Am 01.07.2010 15:24, schrieb Jes Sorensen:
>>      
>>> On 07/01/10 15:22, Stefan Weil wrote:
>>>        
>>>> It won't fail for two reasons:
>>>>
>>>> * It is not redefined (at least for linux systems) because I used the
>>>> POSIX declaration.
>>>>          
>>> This still fails with strict compiler flags.
>>>
>>>        
>>>> * It is compiled only for _WIN32 (see line 95).
>>>>          
>>> True, but we need to move stuff out of osdep.h and into the other files
>>> as much as possible, so it is still preferred that you move it.
>>>        
>> That's a valid argument. As there is more stuff to move out of osdep.h,
>> I suggest doing that in a second step. Now, it is most important to get
>> Windows builds working again (they fail currently with a linker error).
>>      
> Rather than add it to remove it in the next patch, please update your
> patch and repost it. That causes less noise and will get win32 building
> again just as fast.
>
> Cheers,
> Jes
>    

Two patches are needed anyway.

For reasons of economy, I won't send a new patch.
Feel free do send one which meets your criteria.

Regards,
Stefan