From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47739 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUZju-0000tO-EV for qemu-devel@nongnu.org; Fri, 02 Jul 2010 02:28:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUZjt-0000Pi-0b for qemu-devel@nongnu.org; Fri, 02 Jul 2010 02:28:42 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:39635) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUZjs-0000Oj-Hv for qemu-devel@nongnu.org; Fri, 02 Jul 2010 02:28:40 -0400 Received: from m3.gw.fujitsu.co.jp ([10.0.50.73]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o626SYMM018774 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Fri, 2 Jul 2010 15:28:34 +0900 Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id AC7F145DE4F for ; Fri, 2 Jul 2010 15:28:33 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6633E45DE4E for ; Fri, 2 Jul 2010 15:28:33 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id AD1ABE08001 for ; Fri, 2 Jul 2010 15:28:32 +0900 (JST) Received: from m108.s.css.fujitsu.com (m108.s.css.fujitsu.com [10.249.87.108]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 05C3EE08004 for ; Fri, 2 Jul 2010 15:28:29 +0900 (JST) Message-ID: <4C2D86ED.4080108@jp.fujitsu.com> Date: Fri, 02 Jul 2010 15:27:57 +0900 From: Hidetoshi Seto MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean References: <4C2C0C5D.8030905@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org (2010/07/02 4:48), Blue Swirl wrote: > 2010/7/1 Hidetoshi Seto : >> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean". >> >> Signed-off-by: Hidetoshi Seto >> --- >> Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 560eac6..ce5f0e6 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -159,7 +159,7 @@ clean: >> # avoid old build problems by removing potentially incorrect old files >> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h >> rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~ >> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d >> + rm -f {slirp,audio,block,net,fsdev}/*.{o,d} > > Not every shell out there support {}: > dash -c 'echo {a,b}*.c' > {a,b}*.c > > bash -c 'echo {a,b}*.c' > acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c > balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c > buffered_file.c You are right, but I found that Makefile already has: 169 distclean: clean (snip) 174 rm -f qemu-{doc,tech}.{info,aux,cp,dvi,fn,info,ky,log,pdf,pg,toc,tp,vr} So then is it better to rewrite this line not to use {} ...? Thanks, S.Seto