qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Paul Brook <paul@codesourcery.com>
Cc: Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups
Date: Sat, 03 Jul 2010 09:39:39 +0200	[thread overview]
Message-ID: <4C2EE93B.8030003@web.de> (raw)
In-Reply-To: <201007012240.51967.paul@codesourcery.com>

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Paul Brook wrote:
>> I really see no tangible objection to Jan's patches.  They don't impact
>> any other code.  They don't inhibit flexibility in the infrastructure.
>> You might consider it to be a "hack" but so what.  QEMU is filled with
>> hacks.  It would be useless without them because there would be very
>> little code.
> 
> I object strongly to anything that makes qemu_irq a message passing API.
> if you want message passing then you should not be using qemu_irq.

Blueswirl objected to the straightforward return-value approach I first
posted. You seems to be more open towards this, right? Still looks like
I cannot make you both happy at the same time. So what to do?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2010-07-03  7:39 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-29 21:18 [Qemu-devel] [Bug 599958] [NEW] Timedrift problems with Win7 + qemu-kvm Lucas Meneghel Rodrigues
2010-06-29 21:18 ` [Qemu-devel] [Bug 599958] " Lucas Meneghel Rodrigues
2010-06-29 21:18 ` Lucas Meneghel Rodrigues
2010-06-29 21:19 ` Lucas Meneghel Rodrigues
2010-06-29 21:45 ` Anthony Liguori
2010-06-29 21:53 ` Lucas Meneghel Rodrigues
2010-06-30 14:17 ` Lucas Meneghel Rodrigues
2010-06-30 14:38 ` [Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups Anthony Liguori
2010-07-01  7:13   ` [Qemu-devel] " Jan Kiszka
2010-07-01  8:19     ` Gleb Natapov
2010-07-01 15:45       ` Paul Brook
2010-07-01 18:50         ` Anthony Liguori
2010-07-01 21:40           ` Paul Brook
2010-07-03  7:39             ` Jan Kiszka [this message]
2010-07-03  7:49               ` Blue Swirl
2010-07-03  7:55                 ` Jan Kiszka
2010-07-04 22:06                   ` Paul Brook
2010-07-05  6:39                     ` Jan Kiszka
2010-07-05  6:42                       ` Gleb Natapov
2010-07-05  6:49                         ` Jan Kiszka
2010-07-05  7:00                           ` Gleb Natapov
2010-07-05  7:36                             ` Jan Kiszka
2010-07-05  8:47                               ` Avi Kivity
2010-07-05  9:07                                 ` Jan Kiszka
2010-07-05  9:09                                   ` Gleb Natapov
2010-07-05  9:23                                   ` Avi Kivity
2010-07-05 11:13                                     ` Jan Kiszka
2010-07-05 11:40                                       ` Avi Kivity
2010-07-05 12:16                                         ` Jan Kiszka
2010-07-05 12:20                                           ` Gleb Natapov
2010-07-05 13:24                                             ` Jan Kiszka
2010-07-05 13:42                                               ` Avi Kivity
2010-07-05 13:44                                                 ` Gleb Natapov
2010-07-05 12:23                                           ` Avi Kivity
2010-07-05 13:28                                             ` Jan Kiszka
2010-07-05 13:47                                               ` Avi Kivity
2010-07-05 17:12                                                 ` Blue Swirl
2010-07-05 17:32                                                   ` Jan Kiszka
2010-07-05 17:45                                                   ` Avi Kivity
2010-07-01 18:42     ` Anthony Liguori
2010-06-30 15:40 ` [Qemu-devel] " Lucas Meneghel Rodrigues
2013-10-01  9:34 ` Ben A
2013-10-01 15:56   ` Gleb Natapov
2013-10-01 16:23     ` Ben "Root" Anderson
2013-10-01 16:33       ` Gleb Natapov
2013-10-01 16:36         ` Ben "Root" Anderson
2013-10-01 16:47           ` Gleb Natapov
2013-10-01  9:35 ` Ben A
2014-06-15 23:31 ` AndCycle
2019-05-22  7:27 ` Thomas Huth
2019-05-24 14:58 ` Lucas Meneghel Rodrigues
2019-07-24  4:17 ` Launchpad Bug Tracker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2EE93B.8030003@web.de \
    --to=jan.kiszka@web.de \
    --cc=gleb@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).