From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43365 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVfUm-0001HE-7Q for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVfUl-0000ta-1C for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:49:36 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:46482) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVfUk-0000tI-HE for qemu-devel@nongnu.org; Mon, 05 Jul 2010 02:49:34 -0400 Message-ID: <4C31807B.2030401@web.de> Date: Mon, 05 Jul 2010 08:49:31 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups References: <20100629211802.16137.10587.malonedeb@soybean.canonical.com> <4C2EECE8.8030305@web.de> <201007042306.57852.paul@codesourcery.com> <4C317E2A.7090101@web.de> <20100705064239.GI4689@redhat.com> In-Reply-To: <20100705064239.GI4689@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig297A192D7602D06D81571976" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Blue Swirl , Paul Brook , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig297A192D7602D06D81571976 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Gleb Natapov wrote: > On Mon, Jul 05, 2010 at 08:39:38AM +0200, Jan Kiszka wrote: >> Paul Brook wrote: >>>> Blue Swirl wrote: >>>>> On Sat, Jul 3, 2010 at 7:39 AM, Jan Kiszka wrot= e: >>>>>> Paul Brook wrote: >>>>>>>> I really see no tangible objection to Jan's patches. They don't= >>>>>>>> impact any other code. They don't inhibit flexibility in the >>>>>>>> infrastructure. You might consider it to be a "hack" but so what= =2E=20 >>>>>>>> QEMU is filled with hacks. It would be useless without them bec= ause >>>>>>>> there would be very little code. >>>>>>> I object strongly to anything that makes qemu_irq a message passi= ng >>>>>>> API. if you want message passing then you should not be using >>>>>>> qemu_irq. >>>>>> Blueswirl objected to the straightforward return-value approach I = first >>>>>> posted. You seems to be more open towards this, right? Still looks= like >>>>>> I cannot make you both happy at the same time. So what to do? >>>>> I have withdrawn my objection. We can do message passing with some >>>>> different API later, for simple coalescing needs the return value >>>>> approach is enough. >>>> Great! I'll respin my patches ASAP. >>> Note that I still have some concerns over the semantics of that API. >>> I believe this should be fundamentally state based, not event based. >> For the caller of qemu_set_irq, it will be like that. >> > Unfortunately just having qemu_set_irq() return value is not enough to > fix timedrift problem for all Windows. For some of them you need to kno= w > _which_ CPU accepted IRQ. Return values: < 0 - no state change, specifically due to masking or latching >=3D 0 - first CPU (lowest index) on which a state change was achieved Sufficient? Jan --------------enig297A192D7602D06D81571976 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkwxgHsACgkQitSsb3rl5xRcVgCfSbDbtO3ZTr5wf+Rmhf6SyjJT HC4AoOVWGvV4dYh4bgAhDuCtQTt8K3gV =B9Mu -----END PGP SIGNATURE----- --------------enig297A192D7602D06D81571976--