From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58534 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OVhtX-0000VR-5R
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 05:23:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OVhtU-0003er-Ex
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 05:23:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55657)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OVhtU-0003ef-6h
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 05:23:16 -0400
Message-ID: <4C31A477.7010205@redhat.com>
Date: Mon, 05 Jul 2010 12:23:03 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7:
	hpet missing time drift fixups
References: <20100629211802.16137.10587.malonedeb@soybean.canonical.com>	<AANLkTikwwlHm--1-yCquTZwdonYn0soYguEIQoOw0N1R@mail.gmail.com>	<4C2EECE8.8030305@web.de>	<201007042306.57852.paul@codesourcery.com>	<4C317E2A.7090101@web.de>
	<20100705064239.GI4689@redhat.com>	<4C31807B.2030401@web.de>
	<20100705070017.GJ4689@redhat.com> <4C318B74.3040403@web.de>
	<4C319C30.30308@redhat.com> <4C31A0EC.7020803@web.de>
In-Reply-To: <4C31A0EC.7020803@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org

On 07/05/2010 12:07 PM, Jan Kiszka wrote:
>
>> What about ack notifiers?  Ask the APIC to notify you when an interrupt
>> is acked.  That allows you to track the BSP, all cpus, or some subset.
>> Masking can be seen at the irq controller level.
>>      
> So, if I understand you correctly, an IRQ state change that is ignored
> due to masking would invoke the ack notifier chain as well?
>    

No - the cpu doesn't ack, no ack notifier.

We might need a separate mask notifier.  Just add pomodoro sauce.

>> It's more involved, but provides more information.
>>      
> Well, it requires to establish ack notifier chains in parallel to the
> existing IRQ delivery routes. Definitely more invasive.
>    

Right, and need to plumb it twice, once for qemu and once for kvm.

But my feeling is you get a lot more information out of it.

-- 
error compiling committee.c: too many arguments to function