From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46562 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OVlwE-0000cQ-GU
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 09:42:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OVlwC-000446-KE
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 09:42:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56227)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OVlwC-00043y-AP
	for qemu-devel@nongnu.org; Mon, 05 Jul 2010 09:42:20 -0400
Message-ID: <4C31E12E.6090300@redhat.com>
Date: Mon, 05 Jul 2010 16:42:06 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [Bug 599958] Re: Timedrift problems with Win7:
	hpet missing time drift fixups
References: <20100705064239.GI4689@redhat.com> <4C31807B.2030401@web.de>
	<20100705070017.GJ4689@redhat.com> <4C318B74.3040403@web.de>
	<4C319C30.30308@redhat.com> <4C31A0EC.7020803@web.de>
	<4C31A477.7010205@redhat.com> <4C31BE6A.70307@siemens.com>
	<4C31C4A3.4070208@redhat.com> <4C31CD38.5050904@siemens.com>
	<20100705122025.GQ4689@redhat.com> <4C31DD24.6080500@siemens.com>
In-Reply-To: <4C31DD24.6080500@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paul Brook <paul@codesourcery.com>, Gleb Natapov <gleb@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 07/05/2010 04:24 PM, Jan Kiszka wrote:
>
> But how to deal with multiple acks per input due to multiple open
> outputs (not just to different CPUs)?

That will be very rare (i.e. guest bug).

> We either need to enable the
> router to filter redundant information or support the injection source
> with processing all acks properly.
>
> And is there some scenario where the time-keeping device is sharing its
> IRQ line with some other device? De-coalescing workarounds would not
> work then if they were notifier based.
>    

In that case the timekeeping device needs to expose some kind of 
register the guest reads, to distinguish among the various sources.  If 
that's the case, then the qemu timekeeping code can look at accesses to 
this register instead of acks/deliveries.

-- 
error compiling committee.c: too many arguments to function