From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43692 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVnlp-0001yT-2D for qemu-devel@nongnu.org; Mon, 05 Jul 2010 11:39:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVnln-0003Kb-SQ for qemu-devel@nongnu.org; Mon, 05 Jul 2010 11:39:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1025) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVnln-0003KI-Hy for qemu-devel@nongnu.org; Mon, 05 Jul 2010 11:39:43 -0400 Message-ID: <4C31FCB2.8050207@redhat.com> Date: Mon, 05 Jul 2010 17:39:30 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1277898942-6501-1-git-send-email-armbru@redhat.com> <1277898942-6501-5-git-send-email-armbru@redhat.com> In-Reply-To: <1277898942-6501-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 04/11] scsi: Reject unimplemented error actions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com Am 30.06.2010 13:55, schrieb Markus Armbruster: > drive_init() doesn't permit rerror for if=scsi, but that's worthless: > we get it via if=none and -device. > > Moreover, scsi-generic doesn't support werror. Since drive_init() > doesn't catch that, option werror was silently ignored even with > if=scsi. > > Signed-off-by: Markus Armbruster It's still not entirely right, of course. You can explicitly request werror=enospc and the VM will start successfully, but silently ignore ENOSPC errors. Anyway, it's better than before. Kevin