* [Qemu-devel] Latest "git" version fails to compile on Linux host
@ 2010-07-06 8:40 Nigel Horne
2010-07-06 8:49 ` [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Nigel Horne @ 2010-07-06 8:40 UTC (permalink / raw)
To: qemu-devel
./configure --enable-linux-aio --enable-io-thread --enable-kvm
make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
use in this function)
/home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
reported only once
/home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
Perhaps cpus.c needs to have:
extern volatile sig_atomic_t exit_request;
-Nigel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
2010-07-06 8:40 [Qemu-devel] Latest "git" version fails to compile on Linux host Nigel Horne
@ 2010-07-06 8:49 ` Jan Kiszka
2010-07-06 15:46 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2010-07-06 8:49 UTC (permalink / raw)
To: Nigel Horne; +Cc: Paolo Bonzini, qemu-devel
Nigel Horne wrote:
> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
> make
> ...
> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
> use in this function)
> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
> reported only once
> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>
> Perhaps cpus.c needs to have:
>
> extern volatile sig_atomic_t exit_request;
Better include the header:
---------->
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
cpus.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/cpus.c b/cpus.c
index fcd0f09..eef0bb8 100644
--- a/cpus.c
+++ b/cpus.c
@@ -30,6 +30,7 @@
#include "gdbstub.h"
#include "dma.h"
#include "kvm.h"
+#include "exec-all.h"
#include "cpus.h"
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
2010-07-06 8:49 ` [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f Jan Kiszka
@ 2010-07-06 15:46 ` Anthony Liguori
2010-07-06 15:54 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2010-07-06 15:46 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Nigel Horne, Paolo Bonzini, qemu-devel
On 07/06/2010 03:49 AM, Jan Kiszka wrote:
> Nigel Horne wrote:
>
>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>> make
>> ...
>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>> use in this function)
>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>> reported only once
>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>
>> Perhaps cpus.c needs to have:
>>
>> extern volatile sig_atomic_t exit_request;
>>
> Better include the header:
>
> ---------->
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>
Applied. Thanks.
In the future, please try to avoid quoting in like this. I often forget
to remove it from the commit message before pushing (although I did in
this case).
Regards,
Anthony Liguori
> ---
> cpus.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index fcd0f09..eef0bb8 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -30,6 +30,7 @@
> #include "gdbstub.h"
> #include "dma.h"
> #include "kvm.h"
> +#include "exec-all.h"
>
> #include "cpus.h"
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
2010-07-06 15:46 ` Anthony Liguori
@ 2010-07-06 15:54 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2010-07-06 15:54 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Nigel Horne, Paolo Bonzini, qemu-devel@nongnu.org
Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>>> use in this function)
>>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>>> reported only once
>>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>>
>>> Perhaps cpus.c needs to have:
>>>
>>> extern volatile sig_atomic_t exit_request;
>>>
>> Better include the header:
>>
>> ---------->
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>
>
> Applied. Thanks.
>
> In the future, please try to avoid quoting in like this. I often forget
> to remove it from the commit message before pushing (although I did in
> this case).
OK.
Note that there is also 'git am -c' - but I used a non-standard scissors
line here...
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-06 15:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-06 8:40 [Qemu-devel] Latest "git" version fails to compile on Linux host Nigel Horne
2010-07-06 8:49 ` [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f Jan Kiszka
2010-07-06 15:46 ` Anthony Liguori
2010-07-06 15:54 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).