From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59822 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OW7by-00064v-7P
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 08:50:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OW7bx-0001kk-0E
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 08:50:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38629)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OW7bw-0001kd-NI
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 08:50:52 -0400
Message-ID: <4C3326A4.5040201@redhat.com>
Date: Tue, 06 Jul 2010 14:50:44 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1277898942-6501-1-git-send-email-armbru@redhat.com>	<1277898942-6501-9-git-send-email-armbru@redhat.com>	<4C320186.3080804@redhat.com>
	<m3d3v06azg.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3d3v06azg.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/11] ide: Replace IDEState members
 is_cdrom, is_cf by drive_kind
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

Am 06.07.2010 14:38, schrieb Markus Armbruster:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
>> Am 30.06.2010 13:55, schrieb Markus Armbruster:
>>> The two aren't independent variables.  Make that obvious.
>>>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> Can we please call the constant IDE_CDROM or something else that is easy
>> to distinguish? With this patch, we have IDE_CD and IDE_CF, which is an
>> easy typo to make.
> 
> I renamed IDE_CF to IDE_CFATA.  Hope that's okay.

Works for me.

Kevin