From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39665 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWAMT-0007Aq-EP
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWAMO-0002UW-FX
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:02 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:32797)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWAMO-0002UM-8l
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:00 -0400
Received: by gyf2 with SMTP id 2so2484850gyf.4
	for <qemu-devel@nongnu.org>; Tue, 06 Jul 2010 08:46:59 -0700 (PDT)
Message-ID: <4C334FEC.4000604@codemonkey.ws>
Date: Tue, 06 Jul 2010 10:46:52 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f
References: <4C32EBEC.9010204@bandsman.co.uk> <4C32EE35.2040607@siemens.com>
In-Reply-To: <4C32EE35.2040607@siemens.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Nigel Horne <njh@bandsman.co.uk>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 07/06/2010 03:49 AM, Jan Kiszka wrote:
> Nigel Horne wrote:
>    
>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>> make
>> ...
>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>> use in this function)
>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>> reported only once
>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>
>> Perhaps cpus.c needs to have:
>>
>> extern volatile sig_atomic_t exit_request;
>>      
> Better include the header:
>
> ---------->
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>    

Applied.  Thanks.

In the future, please try to avoid quoting in like this.  I often forget 
to remove it from the commit message before pushing (although I did in 
this case).

Regards,

Anthony Liguori
> ---
>   cpus.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index fcd0f09..eef0bb8 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -30,6 +30,7 @@
>   #include "gdbstub.h"
>   #include "dma.h"
>   #include "kvm.h"
> +#include "exec-all.h"
>
>   #include "cpus.h"
>
>