From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39697 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWAMZ-0007Hu-TA
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWAMU-0002WB-6h
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:10 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:52872)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OWAMU-0002Vy-2N
	for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:47:06 -0400
Received: by gwj20 with SMTP id 20so3345933gwj.4
	for <qemu-devel@nongnu.org>; Tue, 06 Jul 2010 08:47:05 -0700 (PDT)
Message-ID: <4C334FF3.9080707@codemonkey.ws>
Date: Tue, 06 Jul 2010 10:46:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h
References: <1278406227-27774-1-git-send-email-Jes.Sorensen@redhat.com>
	<1278406227-27774-2-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1278406227-27774-2-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: frank.arnold@amd.com, qemu-devel@nongnu.org

On 07/06/2010 03:50 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> The result of parsing qemu-options.def depends on whehter or not
> MAP_POPULATE is defined, so make sure to include sys/mman.h before
> including qemu-options.h.
>
> Reported by Frank Arnold.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   os-posix.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index 804e20c..00133a0 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -28,6 +28,8 @@
>   #include<signal.h>
>   #include<sys/types.h>
>   #include<sys/wait.h>
> +/*needed for MAP_POPULATE before including qemu-options.h */
> +#include<sys/mman.h>
>   #include<pwd.h>
>   #include<libgen.h>
>
>