From: Anthony Liguori <anthony@codemonkey.ws>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path
Date: Tue, 06 Jul 2010 14:40:19 -0500 [thread overview]
Message-ID: <4C3386A3.6090605@codemonkey.ws> (raw)
In-Reply-To: <4C2DCA61.2080501@linux.vnet.ibm.com>
On 07/02/2010 06:15 AM, Prerna Saxena wrote:
> Set up host kernel include paths specified by --kerneldir
>
> When host kernel headers are placed in non-standard paths, the
> KVM_CFLAGS are presently invoked only for a few .c files
> (kvm*.c,vhost*.c) and not for other files like machine.c, cpus.c
> ..etc which also depend on linux/kvm.h
I think that's a bug. What's the dependency of machine.c and cpus.c?
Regards,
Anthony Liguori
>
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---
> Makefile.target | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index d58b201..b433112 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -29,12 +29,15 @@ QEMU_PROG=qemu-system-$(TARGET_ARCH2)$(EXESUF)
> endif
> endif
>
> +# Set up host kernel include paths specified by --kerneldir
> +ifdef CONFIG_KVM
> +QEMU_CFLAGS+=$(KVM_CFLAGS)
> +endif
> +
> PROGS=$(QEMU_PROG)
>
> LIBS+=-lm
>
> -kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> -
> config-target.h: config-target.h-timestamp
> config-target.h-timestamp: config-target.mak
>
next prev parent reply other threads:[~2010-07-06 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 11:15 [Qemu-devel] [PATCH] Makefile: Fix compilation for non-standard host kernel path Prerna Saxena
2010-07-06 19:40 ` Anthony Liguori [this message]
2010-07-07 8:26 ` Prerna Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3386A3.6090605@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).