From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWPDg-0003W3-JR for qemu-devel@nongnu.org; Wed, 07 Jul 2010 03:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWPDf-0001Tl-HB for qemu-devel@nongnu.org; Wed, 07 Jul 2010 03:39:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8800) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWPDf-0001TY-9q for qemu-devel@nongnu.org; Wed, 07 Jul 2010 03:38:59 -0400 Message-ID: <4C342F09.2060500@redhat.com> Date: Wed, 07 Jul 2010 09:38:49 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1278419869-26126-1-git-send-email-armbru@redhat.com> <1278419869-26126-7-git-send-email-armbru@redhat.com> <20100707013700.GF3073@lst.de> In-Reply-To: <20100707013700.GF3073@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kraxel@redhat.com, Markus Armbruster , qemu-devel@nongnu.org Am 07.07.2010 03:37, schrieb Christoph Hellwig: > On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote: >> Disk vs. CD needs to be in qdev, because it belongs to the drive's >> guest part. > > Looks good, but the scsi-hd name feelds kinda awkward. This is one > case we're I'm really wondering if the compatiblity is worth it or > if we should just keep using scsi-disk for the real disk. In any case the name should be consistent with ide-hd. And I'm not sure if it's really helpful to have ide-drive and ide-disk. Kevin