* [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
@ 2010-07-01 3:32 Hidetoshi Seto
2010-07-01 19:48 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Hidetoshi Seto @ 2010-07-01 3:32 UTC (permalink / raw)
To: qemu-devel
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 560eac6..ce5f0e6 100644
--- a/Makefile
+++ b/Makefile
@@ -159,7 +159,7 @@ clean:
# avoid old build problems by removing potentially incorrect old files
rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
- rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+ rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
rm -f qemu-img-cmds.h
$(MAKE) -C tests clean
for d in $(ALL_SUBDIRS) libhw32 libhw64 libuser libdis libdis-user; do \
--
1.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
2010-07-01 3:32 [Qemu-devel] " Hidetoshi Seto
@ 2010-07-01 19:48 ` Blue Swirl
2010-07-02 6:27 ` Hidetoshi Seto
0 siblings, 1 reply; 6+ messages in thread
From: Blue Swirl @ 2010-07-01 19:48 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: qemu-devel
2010/7/1 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 560eac6..ce5f0e6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,7 +159,7 @@ clean:
> # avoid old build problems by removing potentially incorrect old files
> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
> + rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
Not every shell out there support {}:
dash -c 'echo {a,b}*.c'
{a,b}*.c
bash -c 'echo {a,b}*.c'
acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c
balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c
buffered_file.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
2010-07-01 19:48 ` Blue Swirl
@ 2010-07-02 6:27 ` Hidetoshi Seto
2010-07-03 7:16 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Hidetoshi Seto @ 2010-07-02 6:27 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
(2010/07/02 4:48), Blue Swirl wrote:
> 2010/7/1 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
>> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>>
>> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
>> ---
>> Makefile | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 560eac6..ce5f0e6 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -159,7 +159,7 @@ clean:
>> # avoid old build problems by removing potentially incorrect old files
>> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
>> rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
>> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
>> + rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
>
> Not every shell out there support {}:
> dash -c 'echo {a,b}*.c'
> {a,b}*.c
>
> bash -c 'echo {a,b}*.c'
> acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c
> balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c
> buffered_file.c
You are right, but I found that Makefile already has:
169 distclean: clean
(snip)
174 rm -f qemu-{doc,tech}.{info,aux,cp,dvi,fn,info,ky,log,pdf,pg,toc,tp,vr}
So then is it better to rewrite this line not to use {} ...?
Thanks,
S.Seto
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
2010-07-02 6:27 ` Hidetoshi Seto
@ 2010-07-03 7:16 ` Blue Swirl
0 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2010-07-03 7:16 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: qemu-devel
On Fri, Jul 2, 2010 at 6:27 AM, Hidetoshi Seto
<seto.hidetoshi@jp.fujitsu.com> wrote:
> (2010/07/02 4:48), Blue Swirl wrote:
>> 2010/7/1 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
>>> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>>>
>>> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
>>> ---
>>> Makefile | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 560eac6..ce5f0e6 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -159,7 +159,7 @@ clean:
>>> # avoid old build problems by removing potentially incorrect old files
>>> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
>>> rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
>>> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
>>> + rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
>>
>> Not every shell out there support {}:
>> dash -c 'echo {a,b}*.c'
>> {a,b}*.c
>>
>> bash -c 'echo {a,b}*.c'
>> acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c
>> balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c
>> buffered_file.c
>
> You are right, but I found that Makefile already has:
>
> 169 distclean: clean
> (snip)
> 174 rm -f qemu-{doc,tech}.{info,aux,cp,dvi,fn,info,ky,log,pdf,pg,toc,tp,vr}
>
> So then is it better to rewrite this line not to use {} ...?
Yes, a patch for that would be nice.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
@ 2010-07-08 5:26 Hidetoshi Seto
2010-07-11 19:27 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Hidetoshi Seto @ 2010-07-08 5:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl
There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 560eac6..7b82a33 100644
--- a/Makefile
+++ b/Makefile
@@ -159,7 +159,7 @@ clean:
# avoid old build problems by removing potentially incorrect old files
rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
- rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
+ rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d
rm -f qemu-img-cmds.h
$(MAKE) -C tests clean
for d in $(ALL_SUBDIRS) libhw32 libhw64 libuser libdis libdis-user; do \
--
1.7.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [PATCH] Makefile: add fsdev/*.{o,d} to clean
2010-07-08 5:26 [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean Hidetoshi Seto
@ 2010-07-11 19:27 ` Blue Swirl
0 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2010-07-11 19:27 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: qemu-devel
Thanks, applied.
2010/7/8 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 560eac6..7b82a33 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,7 +159,7 @@ clean:
> # avoid old build problems by removing potentially incorrect old files
> rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~
> - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d
> + rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d
> rm -f qemu-img-cmds.h
> $(MAKE) -C tests clean
> for d in $(ALL_SUBDIRS) libhw32 libhw64 libuser libdis libdis-user; do \
> --
> 1.7.1.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-11 19:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-08 5:26 [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean Hidetoshi Seto
2010-07-11 19:27 ` [Qemu-devel] " Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2010-07-01 3:32 [Qemu-devel] " Hidetoshi Seto
2010-07-01 19:48 ` Blue Swirl
2010-07-02 6:27 ` Hidetoshi Seto
2010-07-03 7:16 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).