From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41057 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYFgd-0004yd-Ja for qemu-devel@nongnu.org; Mon, 12 Jul 2010 05:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYFgc-0007yD-7a for qemu-devel@nongnu.org; Mon, 12 Jul 2010 05:52:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26185) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYFgc-0007y6-19 for qemu-devel@nongnu.org; Mon, 12 Jul 2010 05:52:30 -0400 Message-ID: <4C3AE5CB.5030908@redhat.com> Date: Mon, 12 Jul 2010 11:52:11 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1278419869-26126-1-git-send-email-armbru@redhat.com> In-Reply-To: <1278419869-26126-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com Am 06.07.2010 14:37, schrieb Markus Armbruster: > This patch series is about purging the "type hint" from the block > layer. My previous series cleaned up improper uses it. Remaining > uses are info block and qdevs ide-drive, scsidisk. > > Remove the type hint from info block. Its value is unreliable anyway. > > ide-drive and scsi-disk can either act as disk or as CD drive. They > use their drive's type hint to decide between disk and CD. This is > unclean. Disk vs. CD needs to be in qdev, not BlockDriverState, > because it belongs to the drive's guest part. > > Split them into separate devices for disk and CD. Keep the old ones > for backward compatibility. > > Bonus fix: reject empty drives unless media is removable (1-3/8). > > This patch series is available at > git://repo.or.cz/qemu/armbru.git > tag block-qdev-split: this series, based on > tag block-fixes-2-v2: my previous series, based on > tag blockdev-base, which the current kevin/block > > Markus Armbruster (8): > virtio-pci: Check for virtio_blk_init() failure > virtio-blk: Fix virtio-blk-s390 to require drive > ide scsi virtio-blk: Reject empty drives unless media is removable Thanks, applied patches 1-3 to the block branch. > block QMP: Drop query-block member "type" (type= in info block) > ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" > scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" > blockdev: Store -drive option media in DriveInfo > block: Remove type hint As discussed on IRC last week I'll wait for a respin for the remaining ones. Kevin