From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35187 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYYnK-00007q-OM for qemu-devel@nongnu.org; Tue, 13 Jul 2010 02:16:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYYnJ-0007KA-P0 for qemu-devel@nongnu.org; Tue, 13 Jul 2010 02:16:42 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:60393) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYYnJ-0007J1-Cu for qemu-devel@nongnu.org; Tue, 13 Jul 2010 02:16:41 -0400 Message-ID: <4C3C04C4.8050804@web.de> Date: Tue, 13 Jul 2010 08:16:36 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1278962453-15774-1-git-send-email-miguel.filho@gmail.com> In-Reply-To: <1278962453-15774-1-git-send-email-miguel.filho@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC5F0897CB9B3DA89A8801546" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 0/8] vlan cleanup List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: qemu-devel@nongnu.org, avi@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC5F0897CB9B3DA89A8801546 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Miguel Di Ciurcio Filho wrote: > This series removes the vlan stuff without mercy. I've tried to make th= e steps > as small as possible, but the last one is huge. I did some basic tests = and > networking is still working, so reviews are welcome :-D Sorry, this is a bit too rude. This not only removes the vlan model, something one may talk about, but also the innocent socket back-ends and the useful pcap dump support. Socket back-ends allow quick and easy unprivileged inter-VM network setups. Nothing for production systems, but useful for testing purposes on boxes where taps are not allowed or unhandy to configure. The dump client helps to debug user mode guest networks, namely slirp which you did not remove. If that should become the only use case for vlans with more than 2 nodes, we could think about making it a special feature of backend devices. I'm open for cleanups here, but they do require a bit mercy - and should also mention the reason. Jan >=20 > A next step would be to rename VLANClientState and other structures to = more > proper names. >=20 > Regards, >=20 > Miguel >=20 > --- >=20 > Miguel Di Ciurcio Filho (8): > vlan cleanup: update documentation > vlan cleanup: update options > vlan cleanup: do not depend on socket and dump > vlan cleanup: do not build socket and dump > vlan cleanup: remove socket.h and socket.c > vlan cleanup: remove dump.h and dump.c > vlan cleanup: remove legacy monitor commands > vlan cleanup: remove usage of VLANState >=20 > Makefile.objs | 2 - > hw/qdev-properties.c | 39 ---- > hw/qdev.c | 2 - > hw/qdev.h | 5 - > hw/xen_devconfig.c | 8 +- > hw/xen_nic.c | 1 - > net.c | 425 +++---------------------------------- > net.h | 12 - > net/dump.c | 159 -------------- > net/dump.h | 33 --- > net/slirp.c | 54 ++---- > net/slirp.h | 3 +- > net/socket.c | 573 ------------------------------------------= -------- > net/socket.h | 33 --- > net/tap.c | 9 +- > net/tap.h | 2 +- > net/vde.c | 8 +- > net/vde.h | 2 +- > qemu-common.h | 1 - > qemu-doc.texi | 24 +-- > qemu-monitor.hx | 36 +--- > qemu-options.hx | 120 ++--------- > 22 files changed, 89 insertions(+), 1462 deletions(-) > delete mode 100644 net/dump.c > delete mode 100644 net/dump.h > delete mode 100644 net/socket.c > delete mode 100644 net/socket.h >=20 >=20 >=20 --------------enigC5F0897CB9B3DA89A8801546 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkw8BMgACgkQitSsb3rl5xSIWQCgnPJIO70rGrmh3OE6KEJ+8JAZ 0k8AoJW43scwelqJV7ryuUGwFihJxBnb =Pmoq -----END PGP SIGNATURE----- --------------enigC5F0897CB9B3DA89A8801546--