qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, avi@redhat.com,
	Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/8] vlan cleanup
Date: Tue, 13 Jul 2010 21:08:27 +0200	[thread overview]
Message-ID: <4C3CB9AB.1070607@web.de> (raw)
In-Reply-To: <4C3CB5C1.5010307@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]

Anthony Liguori wrote:
> On 07/13/2010 07:48 AM, Jan Kiszka wrote:
>> Miguel Di Ciurcio Filho wrote:
>>   
>>> On Tue, Jul 13, 2010 at 3:16 AM, Jan Kiszka<jan.kiszka@web.de>  wrote:
>>>     
>>>> Miguel Di Ciurcio Filho wrote:
>>>>       
>>>>> This series removes the vlan stuff without mercy. I've tried to
>>>>> make the steps
>>>>> as small as possible, but the last one is huge. I did some basic
>>>>> tests and
>>>>> networking is still working, so reviews are welcome :-D
>>>>>          
>>>> Sorry, this is a bit too rude. This not only removes the vlan model,
>>>> something one may talk about, but also the innocent socket back-ends
>>>> and
>>>> the useful pcap dump support.
>>>>
>>>> Socket back-ends allow quick and easy unprivileged inter-VM network
>>>> setups. Nothing for production systems, but useful for testing purposes
>>>> on boxes where taps are not allowed or unhandy to configure.
>>>>
>>>>        
>>> I agree that it might be handy sometimes, but one could use VDE for
>>> that too. Runs on user-space and can be tunneled over SSH or netcat
>>> [1].
>>>      
>> Yes, I know. But it requires yet another process as hop. In contrast,
>> peer-to-peer sockets used to be as fast as taps in certain setup (now
>> taps became faster again).
>>    
> 
> Dump is critical to maintain.
> 
> sockets is not terribly useful without vlan.  Honestly, I have a hard
> time agreeing that it's terribly useful to begin with.  I don't buy an
> argument about "ease-of-use" because how to properly configure the
> sockets backend is not at all obvious.

Old style:
 -net socket,listen=:12345
plus
 -net socket,connect=127.0.0.1:12345
and you have linked two VMs. New style would be less handy (unless we
map -net on -netdev once vlans are gone), but still following the same
pattern.

I bet there is only a minor bit missing to get "-netdev socket" working,
given that slirp apparently works. If I had time, I would look into this.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2010-07-13 19:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 19:20 [Qemu-devel] [PATCH 0/8] vlan cleanup Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 1/8] vlan cleanup: update documentation Miguel Di Ciurcio Filho
2010-07-14  6:11   ` Markus Armbruster
2010-07-12 19:20 ` [Qemu-devel] [PATCH 2/8] vlan cleanup: update options Miguel Di Ciurcio Filho
2010-07-14  6:20   ` Markus Armbruster
2010-07-12 19:20 ` [Qemu-devel] [PATCH 3/8] vlan cleanup: do not depend on socket and dump Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 4/8] vlan cleanup: do not build " Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 5/8] vlan cleanup: remove socket.h and socket.c Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 6/8] vlan cleanup: remove dump.h and dump.c Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 7/8] vlan cleanup: remove legacy monitor commands Miguel Di Ciurcio Filho
2010-07-12 19:20 ` [Qemu-devel] [PATCH 8/8] vlan cleanup: remove usage of VLANState Miguel Di Ciurcio Filho
2010-07-14  6:54   ` Markus Armbruster
2010-07-14  7:18     ` [Qemu-devel] " Jan Kiszka
2010-07-13  6:16 ` [Qemu-devel] Re: [PATCH 0/8] vlan cleanup Jan Kiszka
2010-07-13 12:22   ` Miguel Di Ciurcio Filho
2010-07-13 12:48     ` Jan Kiszka
2010-07-13 18:51       ` Anthony Liguori
2010-07-13 19:08         ` Jan Kiszka [this message]
2010-07-13 19:22           ` Anthony Liguori
2010-07-13 20:12             ` Jan Kiszka
2010-07-14  7:08     ` Markus Armbruster
2010-07-14  7:28       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3CB9AB.1070607@web.de \
    --to=jan.kiszka@web.de \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).