[Qemu-devel] Re: [PATCH 8/8] vlan cleanup: remove usage of VLANState

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

Markus Armbruster wrote:
> Miguel Di Ciurcio Filho <miguel.filho@gmail.com> writes:
>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>> index 275f3bc..e2c2a75 100644
>> --- a/qemu-monitor.hx
>> +++ b/qemu-monitor.hx
>> @@ -1224,8 +1224,8 @@ EQMP
>>  #ifdef CONFIG_SLIRP
>>      {
>>          .name       = "hostfwd_add",
>> -        .args_type  = "arg1:s,arg2:s?,arg3:s?",
>> -        .params     = "[vlan_id name] [tcp|udp]:[hostaddr]:hostport-[guestaddr]:guestport",
>> +        .args_type  = "arg1:s,arg2:s?",
>> +        .params     = "[tcp|udp]:[hostaddr]:hostport-[guestaddr]:guestport",
>>          .help       = "redirect TCP or UDP connections from host to guest (requires -net user)",
>>          .mhandler.cmd = net_slirp_hostfwd_add,
>>      },
> 
> params is inconsistent with args_type and net_slirp_hostfwd_add().

Instead of the vlan ID, we need the netdev ID here - actually already
now because we can set up multiple slirp netdevs but cannot address them
via hostfwd_add/remove.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]