From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH] Make default invocation of block drivers safer
Date: Thu, 15 Jul 2010 10:00:41 +0200 [thread overview]
Message-ID: <4C3EC029.7080003@redhat.com> (raw)
In-Reply-To: <4C3DF681.7080304@codemonkey.ws>
Am 14.07.2010 19:40, schrieb Anthony Liguori:
> On 07/14/2010 11:42 AM, Kevin Wolf wrote:
>> However, I wonder why you even bother with adjusting buffers and
>> requests and stuff instead of just returning a straight -EIO. Doing so
>> would have the additional advantage that the expectation of the guest OS
>> matches what is really on the disk (garbage) instead of silently
>> corrupting things.
>>
>
> I started with that approach. My concern is that it would trigger the
> stop-on-error behavior and the result would be far too difficult for a
> management tool/person to deal with.
>
> Scrubbing seemed like a easier-to-use solution.
Right, I didn't consider that. Makes sense then.
Kevin
next prev parent reply other threads:[~2010-07-15 8:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 16:12 [Qemu-devel] [PATCH] Make default invocation of block drivers safer Anthony Liguori
2010-07-14 16:42 ` [Qemu-devel] " Kevin Wolf
2010-07-14 17:40 ` Anthony Liguori
2010-07-15 8:00 ` Kevin Wolf [this message]
2010-07-14 18:43 ` [Qemu-devel] " Christoph Hellwig
2010-07-14 18:50 ` Anthony Liguori
2010-07-15 9:20 ` Daniel P. Berrange
2010-07-15 12:35 ` Anthony Liguori
2010-07-15 15:19 ` Markus Armbruster
2010-07-15 16:20 ` Anthony Liguori
2010-07-15 17:10 ` Kevin Wolf
2010-07-15 17:51 ` Anthony Liguori
2010-07-16 7:30 ` Kevin Wolf
2010-07-16 12:55 ` Stefan Hajnoczi
2010-07-16 13:00 ` Stefan Hajnoczi
2010-07-16 16:06 ` Markus Armbruster
2010-07-16 16:16 ` Anthony Liguori
2010-07-16 16:24 ` Kevin Wolf
2010-07-14 18:53 ` Anthony Liguori
2010-07-14 18:54 ` Aurelien Jarno
2010-07-14 19:04 ` Anthony Liguori
2010-07-15 8:09 ` Kevin Wolf
2010-07-15 9:10 ` Stefan Hajnoczi
2010-07-15 12:57 ` Anthony Liguori
2010-07-15 13:16 ` Kevin Wolf
2010-07-15 13:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3EC029.7080003@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).