From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36372 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZJNF-0004uC-C8 for qemu-devel@nongnu.org; Thu, 15 Jul 2010 04:00:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZJND-00056B-Gh for qemu-devel@nongnu.org; Thu, 15 Jul 2010 04:00:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46599) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZJND-00055z-7J for qemu-devel@nongnu.org; Thu, 15 Jul 2010 04:00:51 -0400 Message-ID: <4C3EC029.7080003@redhat.com> Date: Thu, 15 Jul 2010 10:00:41 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Make default invocation of block drivers safer References: <1279123952-1576-1-git-send-email-aliguori@us.ibm.com> <4C3DE8E3.8080709@redhat.com> <4C3DF681.7080304@codemonkey.ws> In-Reply-To: <4C3DF681.7080304@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi Am 14.07.2010 19:40, schrieb Anthony Liguori: > On 07/14/2010 11:42 AM, Kevin Wolf wrote: >> However, I wonder why you even bother with adjusting buffers and >> requests and stuff instead of just returning a straight -EIO. Doing so >> would have the additional advantage that the expectation of the guest OS >> matches what is really on the disk (garbage) instead of silently >> corrupting things. >> > > I started with that approach. My concern is that it would trigger the > stop-on-error behavior and the result would be far too difficult for a > management tool/person to deal with. > > Scrubbing seemed like a easier-to-use solution. Right, I didn't consider that. Makes sense then. Kevin